[webkit-reviews] review granted: [Bug 39695] FrameLoader cleanup: Merge some bool members into a state machine : [Attachment 58282] No assert failures in layout tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 18 15:58:11 PDT 2010
Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 39695: FrameLoader cleanup: Merge some bool members into a state machine
https://bugs.webkit.org/show_bug.cgi?id=39695
Attachment 58282: No assert failures in layout tests
https://bugs.webkit.org/attachment.cgi?id=58282&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/loader/FrameLoaderStateMachine.h:46
+ Uninitialized = 0,
No need for = 0 here.
WebCore/loader/FrameLoaderStateMachine.cpp:69
+ ASSERT(State(m_state + 1) == state || (firstLayoutDone() && state ==
CommittedFirstRealLoad));
Nice.
More information about the webkit-reviews
mailing list