[webkit-reviews] review granted: [Bug 39395] FrameLoader: eliminate some unnecessary logic from urlSelected() : [Attachment 56722] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 39395: FrameLoader: eliminate some unnecessary logic from urlSelected()
https://bugs.webkit.org/show_bug.cgi?id=39395

Attachment 56722: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=56722&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Mostly questions.  Thanks for digging into this class.

WebCore/loader/FrameLoader.cpp:1781
 +  void FrameLoader::loadFrameRequest(const ResourceRequest& request, const
String& frameName, bool lockHistory, bool lockBackForwardList,
PassRefPtr<Event> event, PassRefPtr<FormState> formState, ReferrerPolicy
referrerPolicy, String origin)
Strange that we use the name |request| for both FrameLoadRequest and
ResourceRequest.  Is that what we do elsewhere?

WebCore/loader/FrameLoader.cpp:1778
 +	loadFrameRequest(request.resourceRequest(), request.frameName(),
lockHistory, lockBackForwardList, event, formState, referrerPolicy, String());
The last arg here is somewhat unfortunate.

WebCore/loader/FrameLoader.cpp:3211
 +  // The inRequest's httpReferrer() is not examined by this method.  The
newReferrer
Crazy

WebCore/loader/FrameLoader.h:385
 +	void addExtraFieldsToRequest(ResourceRequest&, FrameLoadType loadType,
bool isMainResource, bool cookiePolicyURLFromRequest, String httpOrigin);
Why httpOrigin instead of origin?