[webkit-reviews] review granted: [Bug 39156] FrameLoader: refactor FrameLoader::createWindow() to be a non-member, non-friend function : [Attachment 56455] Proposed patch 3

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 39156: FrameLoader: refactor FrameLoader::createWindow() to be a
non-member, non-friend function
https://bugs.webkit.org/show_bug.cgi?id=39156

Attachment 56455: Proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=56455&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/bindings/generic/BindingDOMWindow.h:93
 +	Frame* newFrame = WebCore::createWindow(callingFrame, openerFrame,
frameRequest, windowFeatures, created);
Do we need the WebCore:: prefix here?