[webkit-reviews] review granted: [Bug 40723] Fix paren matching rules for switch/if/while in check-webkit-style script : [Attachment 59011] The right patch this time, sigh.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 21:47:19 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40723: Fix paren matching rules for switch/if/while in check-webkit-style
script
https://bugs.webkit.org/show_bug.cgi?id=40723

Attachment 59011: The right patch this time, sigh.
https://bugs.webkit.org/attachment.cgi?id=59011&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> This actually will spit out the to messages (one for the space after '(' and
one for the space before ')'. I didn't see any other tests that check for two
errors, are there anyway?

I think assert_lint can take a list of errors as the second parameter. Like,

self.assert_lint('while (  foo	) {',
		 ['the first error!',
		  'the second error!'])


More information about the webkit-reviews mailing list