[webkit-reviews] review granted: [Bug 40724] Check for extra spacing on a variable declaration line. : [Attachment 59016] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 21:43:01 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40724: Check for extra spacing on a variable declaration line.
https://bugs.webkit.org/show_bug.cgi?id=40724

Attachment 59016: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=59016&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks great. Thanks for your quick update.

> > - You may have already done this, but please check your patch with existing
code and check if there are new false positives. For example, I often run
./WebKitTools/Scripts/run-webkit-style WebCore/*/*.cpp | grep <the new error
message> to see the change.
> 
> This seemed to pass for me, it even spotted a handful of existing errors :)

Nice! Thanks for your checking.


More information about the webkit-reviews mailing list