[webkit-reviews] review denied: [Bug 40430] [Chromium] Plumbing for top-level frame names : [Attachment 58567] Updated chromium DRT to match new createView() API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 16 13:18:20 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied review:
Bug 40430: [Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430
Attachment 58567: Updated chromium DRT to match new createView() API
https://bugs.webkit.org/attachment.cgi?id=58567&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebFrame.h:106
+ virtual void setName(const WebString&) = 0;
What's the difference between clearName and setName(WebString())?
Looking at the code, setName(WebString()) will assign a unique
name to the frame. Is that what you want this API to do? It
seems like you should document this behavior.
More information about the webkit-reviews
mailing list