[webkit-reviews] review denied: [Bug 38390] [Qt] Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html : [Attachment 54807] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s
request for review:
Bug 38390: [Qt] Failed on
http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.ht
ml
https://bugs.webkit.org/show_bug.cgi?id=38390

Attachment 54807: patch
https://bugs.webkit.org/attachment.cgi?id=54807&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
In principle this looks good to me, but wouldn't it be much nicer if FloatRect
had a member function, like this?

FloatRect FloatRect::normalized() const;

and then you could simply write:

painter->drawPixmap(dst.normalized(), *image, src.normalized())

What do you think?