[webkit-reviews] review denied: [Bug 40649] Pull script line number from DocumentParser instead of pushing it to ScriptController : [Attachment 58848] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied  review:
Bug 40649: Pull script line number from DocumentParser instead of pushing it to
ScriptController
https://bugs.webkit.org/show_bug.cgi?id=40649

Attachment 58848: Patch
https://bugs.webkit.org/attachment.cgi?id=58848&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm changing this to a r-.  I'd like to see perf numbers from this change (from
running our parser benchmark) and I would like to see the lineNumber+1 hack
encapsulated into some sort of function somewhere.  Probably just moved over
into the ScriptController code.  If it had a eventHandlerlineNumber() accessor
which knew how to call the parser and do the +1, that seems simplest.