[webkit-reviews] review granted: [Bug 40650] Enable HTML5 lexer : [Attachment 58850] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 40650: Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Attachment 58850: Patch
https://bugs.webkit.org/attachment.cgi?id=58850&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LayoutTests/ChangeLog:61
 +	    * inspector/timeline-script-tag-1-expected.txt:
Our new behavior is fine.  We just need to file a bug with the inspector to
update their code a bit.

LayoutTests/ChangeLog:60
 +	    * inspector/audits-panel-functional-expected.txt:
Did the explanation for this one go in the wrong place?  Do we need a bug on
this?

LayoutTests/ChangeLog:44
 +		- I don't fully understand this behavior change.  It might
We should file a bug for this.

LayoutTests/ChangeLog:101
 +		  FFFD).  Still investigating whether this is a real bug.
We should probably turn all of these investigations into bugs at this point,
since we're actually changing what everyone is using in their day-to-day
builds.

rs=me.

I've seen all these changes for a while and they look expected.  But we should
be sure to send a note to webkit-dev pointing them to this change so they can
comment about any of these behavioral changes.

Thanks for putting this together.WebCore/page/Settings.cpp:135
 +	, m_html5ParserEnabled(true)
Do we need to change WebKit as well?  I think we might.  Certainly we need to
rename this setting at some point.  If you file a bug on it or add it to the
TODO list I can take care of it.