[webkit-reviews] review requested: [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) : [Attachment 58849] [PATCH] Part 3 - Test Case

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 40627: Limit ApplicationCache Total and Per-Origin Storage Capacity
(Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627

Attachment 58849: [PATCH] Part 3 - Test Case
https://bugs.webkit.org/attachment.cgi?id=58849&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This adds a test case but it doesn't call setQuota directly on an
ApplicationCacheGroup,
instead it uses the preference, and creates a new cache group by changing the
manifest url
(this causes a new group to be created).

After speaking with Alexey, and making these tests, I think "Per-Origin" is the
wrong
name for this bug. And ApplicationCacheGroupQuota is misleading, because its
really a quota on the ApplicationCaches themselves, it just happens that the
size counter
is in ApplicationCacheGroup because thats where the resource loads happen.

So, feel free to suggest better names or suggest that I move things around.