[webkit-reviews] review granted: [Bug 40649] Pull script line number from DocumentParser instead of pushing it to ScriptController : [Attachment 58848] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40649: Pull script line number from DocumentParser instead of pushing it to
ScriptController
https://bugs.webkit.org/show_bug.cgi?id=40649

Attachment 58848: Patch
https://bugs.webkit.org/attachment.cgi?id=58848&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Nits below:

WebCore/bindings/js/ScriptEventListener.cpp:74
 +	    if (DocumentParser* parser = frame->document()->parser())
Wow, so much prettier with the new names.

WebCore/ChangeLog:10
 +	    cleaner IMHO.
Can you measure how much this helps us?  I'm curious what kind of scale change
we need per token to move the benchmark.  I'm pretty sure the benchmark moves
per-branch per-character.

WebCore/bindings/js/ScriptEventListener.cpp:75
 +		lineNumber = parser->lineNumber() + 1;
Can you make this a static inline function just so we can give this wacky
conversion a name?

WebCore/bindings/v8/ScriptEventListener.cpp:68
 +		lineNumber = parser->lineNumber();
No +1 here?