[webkit-reviews] review granted: [Bug 40089] Add a takeFirst() method to Deque and use it where appropriate : [Attachment 57789] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 13:49:26 PDT 2010


Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40089: Add a takeFirst() method to Deque and use it where appropriate
https://bugs.webkit.org/show_bug.cgi?id=40089

Attachment 57789: Patch
https://bugs.webkit.org/attachment.cgi?id=57789&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
LGTM.  Thanks for looking into the details.

WebCore/html/HTMLTokenizer.cpp:217
 +	    CachedScript* cs = m_pendingScripts.takeFirst().get();
I know this does the same thing as before, but it looks sketch.  Who else is
hold a reference to this object for us?


More information about the webkit-reviews mailing list