[webkit-reviews] review granted: [Bug 39725] [Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges : [Attachment 57729] patch v4

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 39725: [Chromium] Dragging over an element with scrollbars should scroll
the element when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725

Attachment 57729: patch v4
https://bugs.webkit.org/attachment.cgi?id=57729&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Looks good except some minor issues. Please land it with these issues
addressed.

WebKit/chromium/public/WebView.h:172
 +	// Notifies the WebView that a dragging is going on.
dragging => drag

WebKit/chromium/src/WebViewImpl.cpp:845
 +	// This margin approximates Safari behavior
Please end the sentence with period.

WebKit/chromium/src/WebViewImpl.cpp:828
 +  // Computes disatances from a point to the nearest point from a rect for
both x and y coordinates.
I think what Darin suggested for the comment is easy to understand. We have
"the distance" represented by a pair of values, not "distances".

WebKit/chromium/src/WebViewImpl.cpp:846
 +	static const int scrollMargin = 30;
Please comment why you pick 30. Maybe you could say that this is based on the
observation of ...