[webkit-reviews] review granted: [Bug 39058] old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests : [Attachment 57738] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 39058: old-run-webkit-tests should use ensure-valid-python to check if it
can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058

Attachment 57738: Patch
https://bugs.webkit.org/attachment.cgi?id=57738&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
>	  print "Your Python version is insuficient to run WebKit's Python
code.  Please update.\n";

Typo: should be "insufficient".

+    `./WebKitTools/Scripts/ensure-valid-python --check-only`;

We normally use system(), not backticks. But there's precedent for the latter,
too.