[webkit-reviews] review requested: [Bug 40128] Regressions in debug functionality : [Attachment 57785] suggested patch

[bugzilla-daemon at webkit.org]

Nathan Lawrence <nlawrence at apple.com> has asked  for review:
Bug 40128: Regressions in debug functionality
https://bugs.webkit.org/show_bug.cgi?id=40128

Attachment 57785: suggested patch
https://bugs.webkit.org/attachment.cgi?id=57785&action=review

------- Additional Comments from Nathan Lawrence <nlawrence at apple.com>
There are a few things that don't work anymore but are useful for debugging:

* JS_ZOMBIES doesn't compile anymore.

* The dumpCallFrame function in the interpreter causes a runtime error because
JSValue::description does not match the current state of JSValue

* The dumpRegisters function in the interpreter is not up to date with the most
recent call frame patches.

* Additionally it would be nice if JSValue::isCell checked that the value was
aligned.