[webkit-reviews] review denied: [Bug 39680] [Qt] Expose the editing behavior setting in DRT to test all editing code paths : [Attachment 57572] patch v2 - adding ASSERT_NOT_REACHED

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 39680: [Qt] Expose the editing behavior setting in DRT to test all editing
code paths
https://bugs.webkit.org/show_bug.cgi?id=39680

Attachment 57572: patch v2 - adding ASSERT_NOT_REACHED
https://bugs.webkit.org/attachment.cgi?id=57572&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
When I add ASSERT_NOT_REACHED I often put a comment as to why it should not be
reached.  In this case:

# You've hit this ASSERT either because the layout test is using an invalid
string or because Qt's DumpRenderTree is missing support for that editing
behavior.

You've added an unconditional return due to missing {}