[webkit-reviews] review granted: [Bug 39282] Slave lost shouldn't be recognized as build failed : [Attachment 56355] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 1 11:30:26 PDT 2010
Eric Seidel <eric at webkit.org> has granted Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 39282: Slave lost shouldn't be recognized as build failed
https://bugs.webkit.org/show_bug.cgi?id=39282
Attachment 56355: proposed patch
https://bugs.webkit.org/attachment.cgi?id=56355&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Please add a FIXME comment. Something like:
# FIXME: We treat slave lost as green even though it is not to work
# around the Qts bot being on a broken internet connection.
# The real fix is https://bugs.webkit.org/show_bug.cgi?id=37099
But this solution is pragmatic and we should do it.
More information about the webkit-reviews
mailing list