[webkit-reviews] review granted: [Bug 43232] Replace plugins/npruntime/bindings-test.html with a more sophisticated test : [Attachment 63031] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 43232: Replace plugins/npruntime/bindings-test.html with a more
sophisticated test
https://bugs.webkit.org/show_bug.cgi?id=43232

Attachment 63031: Patch
https://bugs.webkit.org/attachment.cgi?id=63031&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  2010-07-29  Anders Carlsson	<andersca at apple.com>
>  
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Replace plugins/npruntime/bindings-test.html with a more
sophisticated test
> +	   https://bugs.webkit.org/show_bug.cgi?id=43232
> +
> +	   * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
> +	   * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
> +	   (pluginInvoke):
> +	   * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
> +	   (PluginTest::create):
> +	   (PluginTest::NPP_GetValue):
> +	   (PluginTest::NPN_CreateObject):
> +	   (PluginTest::createTestFunctions):
> +	   * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
> +	   (PluginTest::identifier):
> +	   *
DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
> +	   (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
> +	   * DumpRenderTree/TestNetscapePlugIn/main.cpp:
> +	   (NPP_GetValue):
> +	   * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
> +	   * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
> +	   * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
> +	   (webkit_test_plugin_get_value):
> +	   * GNUmakefile.am:

Can you describe the changes a bit?

> -static bool removeDefaultMethod(PluginObject*, const NPVariant* args,
uint32_t argCount, NPVariant* result)
> -{
> -    pluginClass.invokeDefault = 0;
> -    VOID_TO_NPVARIANT(*result);
> -    return true;
> -}

Is it worthwhile to test that a plugin can dynamically remove its invokeDefault
implementation? You've lost that aspect of the test.

r=me