[webkit-reviews] review denied: [Bug 25645] SVG - numeric overflow for very large elements : [Attachment 62940] Revised (vD) patch to fix SVG number parsing of large numbers

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 25645: SVG - numeric overflow for very large elements
https://bugs.webkit.org/show_bug.cgi?id=25645

Attachment 62940: Revised (vD) patch to fix SVG number parsing of large numbers
https://bugs.webkit.org/attachment.cgi?id=62940&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r-, ChangeLogs are missing. And some additional issues:

WebCore/svg/SVGParserUtilities.cpp:70
 +	  ++ptr; // Advance to first non-digit.
Four-spaces indention please.

WebCore/svg/SVGParserUtilities.cpp:73
 +	  const UChar* ptrScanIntPart = ptr - 1;
Ditto.

WebCore/svg/SVGParserUtilities.cpp:76
 +	    integer = integer + multiplier *
static_cast<FloatType>(*(ptrScanIntPart--) - '0');
Ditto. And you can use integer += multipler * ... here.