[webkit-reviews] review requested: [Bug 31302] Add WOFF support for @font-face : [Attachment 63035] Add ConvertWOFFToSfnt() and use it on Mac and Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 00:38:21 PDT 2010


mitz at webkit.org has asked  for review:
Bug 31302: Add WOFF support for @font-face
https://bugs.webkit.org/show_bug.cgi?id=31302

Attachment 63035: Add ConvertWOFFToSfnt() and use it on Mac and Windows
https://bugs.webkit.org/attachment.cgi?id=63035&action=review

------- Additional Comments from mitz at webkit.org
Addressed some of the comments. The sfnt vector now grows incrementally as it
is being written into, however for each font table, memory allocation is still
attempted for whatever uncompressed size the WOFF table directory claims that
the table has, as uncompress() offers no way to verify the claim without
uncompressing into a buffer.


More information about the webkit-reviews mailing list