[webkit-reviews] review requested: [Bug 40092] spellcheck does not check pasted text : [Attachment 63034] Draft implementation #4

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 40092: spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Attachment 63034: Draft implementation #4
https://bugs.webkit.org/attachment.cgi?id=63034&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Eric,

Thank you for your review and comments.
I have added the AsyncSpellCheckerController class to encapsulate some
spellchecker-specific code and apply your comments. (I may miss some of them,
though.)

(In reply to comment #13)
> WebKit/mac/WebCoreSupport/WebEditorClient.mm:827
>  +  #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_6 &&
NS_BLOCKS_AVAILABLE
> NS_BLOCKS_AVAILABLE?

This define means we can use GCD (Grand Central Dispatch), which is required by
[NSSpellChecker requestCheckingOfString:]. (Even though GCD is enabled by
default on 10.6, we can disable it. So it may be safer to add this define in my
code.)

It is definitely helpful to review the updated one and give me your comments?

Regards,

Hironori Bono