[webkit-reviews] review denied: [Bug 37505] Enabling view modes to all platforms : [Attachment 62972] improving changelogs

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 37505: Enabling view modes to all platforms
https://bugs.webkit.org/show_bug.cgi?id=37505

Attachment 62972: improving changelogs
https://bugs.webkit.org/attachment.cgi?id=62972&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I don't like how the view mode strings used in createViewModesSet(), and passed
into setViewMode() from outside have to match. That makes it too easy for
platforms to unintentionally diverge. I think I'd prefer:

enum ViewMode {
...
};
void Page::viewModeChanged(ViewMode) which the platform calls when something
changes that affects the view mode. Do the enum -> string mapping in one place.