[webkit-reviews] review granted: [Bug 43206] Ask a canvas' rendering context if it is accelerated instead tying it directly to webgl : [Attachment 62978] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 13:10:04 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 43206: Ask a canvas' rendering context if it is accelerated instead tying
it directly to webgl
https://bugs.webkit.org/show_bug.cgi?id=43206

Attachment 62978: Patch
https://bugs.webkit.org/attachment.cgi?id=62978&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
>  #if ENABLE(3D_CANVAS)
>      HTMLCanvasElement* canvas = static_cast<HTMLCanvasElement*>(node());
> -    return canvas && canvas->is3D();
> +    return canvas && canvas->renderingContext() &&
canvas->renderingContext()->isAccelerated();

No need for the #if ENABLE(3D_CANVAS) any more?


More information about the webkit-reviews mailing list