[webkit-reviews] review denied: [Bug 42885] [WINCE] Merge PasteboardWince.cpp into PasteboardWin.cpp : [Attachment 62409] Patch (improved version)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 23 08:31:48 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 42885: [WINCE] Merge PasteboardWince.cpp into PasteboardWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42885
Attachment 62409: Patch (improved version)
https://bugs.webkit.org/attachment.cgi?id=62409&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Pasteboard::Pasteboard()
> -{
> - // make a dummy HWND to be the Windows clipboard's owner
> - WNDCLASSEX wcex = {0};
> +{
> + HWND hWndParent = 0;
> +#if OS(WINCE)
> + WNDCLASS wcex;
> + memset(&wcex, 0, sizeof(WNDCLASS));
> +#else
> + WNDCLASSEX wcex;
> + memset(&wcex, 0, sizeof(WNDCLASSEX));
> wcex.cbSize = sizeof(WNDCLASSEX);
> +#endif
> wcex.lpfnWndProc = PasteboardOwnerWndProc;
> - wcex.hInstance = WebCore::instanceHandle();
> wcex.lpszClassName = L"PasteboardOwnerWindowClass";
> - ::RegisterClassEx(&wcex);
> +#if OS(WINCE)
> + RegisterClass(&wcex);
> +#else
> + RegisterClassEx(&wcex);
> + hWndParent = HWND_MESSAGE;
> +#endif
I think we can make non-CE Windows use WNDCLASS and RegisterClass, too. I think
the reduced complexity is worth it.
Why was the setting of the hInstance member removed?
More information about the webkit-reviews
mailing list