[webkit-reviews] review granted: [Bug 42843] Interrupt all DB operations when a worker is shutting down : [Attachment 62337] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 22 21:24:37 PDT 2010


Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 42843: Interrupt all DB operations when a worker is shutting down
https://bugs.webkit.org/show_bug.cgi?id=42843

Attachment 62337: patch
https://bugs.webkit.org/attachment.cgi?id=62337&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This threading stuff is all very complicated.  I'm not sure I fully grasp the
locking discipline, but this looks reasonable to me.

WebCore/storage/chromium/DatabaseTrackerChromium.cpp:181
 +  void
DatabaseTracker::interruptAllDatabasesForContext(ScriptExecutionContext*
context)
Sad that we have to copy/paste this code.


More information about the webkit-reviews mailing list