[webkit-reviews] review denied: [Bug 42805] TextEvent should have inputMode property : [Attachment 62370] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 22 20:29:29 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 42805: TextEvent should have inputMode property
https://bugs.webkit.org/show_bug.cgi?id=42805

Attachment 62370: Patch
https://bugs.webkit.org/attachment.cgi?id=62370&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Pasting and dropping can be distinguished from other input - in fact, we
already have such a distinction, see EditorInsertAction.h in WebCore. We don't
expose that to JS code as far as I know, and it may be useful indeed.

However, please note that text added via insertText: can also be styled - the
caller can always pass an NSAttributedString there.

I'm marking the patch r-, as I don't see why we would want to expose all the
other options currently in DOM 3 events.


More information about the webkit-reviews mailing list