[webkit-reviews] review granted: [Bug 42301] [Chromium] Use the unique ID instead of the profile label to identify the accepted AutoFill suggestion. : [Attachment 61579] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 16:55:37 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Hawkins
<jhawkins at chromium.org>'s request for review:
Bug 42301: [Chromium] Use the unique ID instead of the profile label to
identify the accepted AutoFill suggestion.
https://bugs.webkit.org/show_bug.cgi?id=42301

Attachment 61579: Patch
https://bugs.webkit.org/attachment.cgi?id=61579&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebView.h:258
 +	// Notifies the WebView that AutoFill suggestions are available for a
node.
it might be nice to explain what the uniqueIDs parameter is
all about.  it isn't very obvious from reading the signature
of the method.

R=me


More information about the webkit-reviews mailing list