[webkit-reviews] review granted: [Bug 42203] [chromium] GLES2Context is in platform/ and shouldn't depend on Page : [Attachment 61581] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 42203: [chromium] GLES2Context is in platform/ and shouldn't depend on Page
https://bugs.webkit.org/show_bug.cgi?id=42203

Attachment 61581: Patch
https://bugs.webkit.org/attachment.cgi?id=61581&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebGLES2Context.h:49
 +	WEBKIT_API virtual bool initialize(WebView*, WebGLES2Context* parent) =
0;
no need for WEBKIT_API on virtual methods.  no need to export
these from WebKit when it is built as a DLL.
WebKit/chromium/src/GLES2ContextInternal.h:55
 +  }
} // namespace WebCore

WebKit/chromium/src/WebViewImpl.cpp:2139
 +	return
WebCore::GLES2Context::create(WebCore::GLES2ContextInternal::create(gles2Contex
t(), false));
no need for the WebCore:: prefix in this .cpp file given the 
using declaration at the top of the file.

WebKit/chromium/src/WebViewImpl.cpp:2142
 +  PassOwnPtr<WebCore::GLES2Context> WebViewImpl::getOffscreenGLES2Context()
ditto about the WebCore:: prefix

otherwise, R=me with these nits addressed.