[webkit-reviews] review granted: [Bug 42222] reconstructActiveFormElements should reconstruct attributes as well : [Attachment 61453] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 42222: reconstructActiveFormElements should reconstruct attributes as well
https://bugs.webkit.org/show_bug.cgi?id=42222

Attachment 61453: Patch
https://bugs.webkit.org/attachment.cgi?id=61453&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
LayoutTests/ChangeLog:5
 +	    reconstructActiveFormElements should reconstruct attributes instead

instead?

LayoutTests/html5lib/resources/adoption01.dat:163
 +  |		"document.getElementById("A").id = "B""
Nice test.  Will this cause problems for us when we upstream these tests?  We
might want to separate tests that require scripts into their own dat file.

WebCore/html/HTMLConstructionSite.cpp:303
 +  namespace {
Please place this block at the top of the file.

WebCore/html/HTMLConstructionSite.h:67
 +	// Used by the adoption agency.
Please remove this comment.