[webkit-reviews] review granted: [Bug 20011] Printing test results differ between machines, we should use ImageDiff instead : [Attachment 55528] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 09:56:48 PDT 2010


Darin Adler <darin at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 20011: Printing test results differ between machines, we should use
ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

Attachment 55528: Patch v1
https://bugs.webkit.org/attachment.cgi?id=55528&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems OK.

WebCore/page/PrintContext.cpp:244
 +		graphicsContext.drawLine(IntPoint(0, currentHeight),
 +					 IntPoint(pageWidth, currentHeight));
Not our usual formatting. Put it all on one line, or indent by 4 spaces. Please
don't indent to match the parenthesis on the line above.


More information about the webkit-reviews mailing list