[webkit-reviews] review granted: [Bug 41461] Web Inspector: all breakpoints are activated on page reload : [Attachment 61055] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 01:59:19 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 41461: Web Inspector: all breakpoints are activated on page reload
https://bugs.webkit.org/show_bug.cgi?id=41461

Attachment 61055: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=61055&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:41
 +	    if (!WebInspector.flag) {
I'd rather use more specific variable name or something like
frontend_testBreakpointsNotActivatedOnReload.flag to avoid possible conflicts.


More information about the webkit-reviews mailing list