[webkit-reviews] review denied: [Bug 42093] Change handling of -khtml- and -apple- vendor-prefixes : [Attachment 61342] Idem, but with a style fix

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Peter Beverloo <peter at lvp-media.com>'s
request for review:
Bug 42093: Change handling of -khtml- and -apple- vendor-prefixes
https://bugs.webkit.org/show_bug.cgi?id=42093

Attachment 61342: Idem, but with a style fix
https://bugs.webkit.org/attachment.cgi?id=61342&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/css/CSSParser.cpp:5583
 +	    if (!strcmp(buffer, "-apple-dashboard-region") || !strcmp(buffer,
"-apple-line-clamp")) {
This looks wrong.  Previously the variable "length" was updated by "hasPrefix".
 That's no longer the case, so the memmove will be wrong.  Do we not have tests
for these?  We should add them.