[webkit-reviews] review granted: [Bug 42032] Need to emulate MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for glGet : [Attachment 61162] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Zhenyao Mo
<zmo at google.com>'s request for review:
Bug 42032: Need to emulate
MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for
glGet
https://bugs.webkit.org/show_bug.cgi?id=42032

Attachment 61162: patch
https://bugs.webkit.org/attachment.cgi?id=61162&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:1229
 +	    *value /= 4;
nit: you should explain this factor of 4 in the ChangeLog.  desktop GL returns
byte counts or something, and GLES2 needs to return 32bit word counts?

R=me