[webkit-reviews] review granted: [Bug 41381] Need to track texture completeness : [Attachment 60490] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Zhenyao Mo
<zmo at google.com>'s request for review:
Bug 41381: Need to track texture completeness
https://bugs.webkit.org/show_bug.cgi?id=41381

Attachment 60490: patch
https://bugs.webkit.org/attachment.cgi?id=60490&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/html/canvas/WebGLRenderingContext.cpp:1072
 +	RefPtr<WebGLTexture> tex = 0;
nit: no need to explicitly initialize a RefPtr.  the default ctor
initializes it to a null value.

WebCore/html/canvas/WebGLTexture.h:63
 +	    static bool isNPOT(unsigned, unsigned);
note: the NPOT acronym was a mystery to me.  webkit encourages
minimizing the use of acronyms unless they are commonly known
or pertaining to the name of a protocol, etc.  That said,
"site:khronos.org NPOT" told me what I need to know.
isNotPowerOfTwo would probably be a better function name.

R=me