[webkit-reviews] review denied: [Bug 41613] Adds support for generating code from IDL with reserved keywords (it'll be necessary for IDBCursor::continue). : [Attachment 60529] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 07:15:17 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 41613: Adds support for generating code from IDL with reserved keywords
(it'll be necessary for IDBCursor::continue).
https://bugs.webkit.org/show_bug.cgi?id=41613
Attachment 60529: Patch
https://bugs.webkit.org/attachment.cgi?id=60529&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Looks good, except the way you're escaping it doesn't seem very webkitty. Not
sure what'd be a better suffix tho. :-(
Also, you should git blame this and cc some others who work in this code.
More information about the webkit-reviews
mailing list