[webkit-reviews] review denied: [Bug 41616] [Chromium] DeviceOrientation plumbing : [Attachment 60534] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied  review:
Bug 41616: [Chromium] DeviceOrientation plumbing
https://bugs.webkit.org/show_bug.cgi?id=41616

Attachment 60534: Patch
https://bugs.webkit.org/attachment.cgi?id=60534&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebKit/chromium/src/WebViewImpl.h:44
 +  #if ENABLE(DEVICE_ORIENTATION)
We shoudl just turn it on now at compile time, but hide it behind a runtime
flag.  Then you don't need this stuff.

WebKit/chromium/src/WebDeviceOrientationServiceBridgeImpl.h:14
 +   *	   * Neither the name of Google Inc. nor the names of its
Use 2 clause license

WebKit/chromium/src/WebDeviceOrientationServiceBridgeImpl.h:42
 +	explicit
WebDeviceOrientationServiceBridgeImpl(DeviceOrientationClientImpl*
deviceOrientationClientImpl);
only name parameters in .h files when it adds information

WebKit/chromium/src/WebDeviceOrientationServiceBridgeImpl.cpp:89
 +	m_webDeviceOrientationService = NULL;
use 0 not NULL in webkit code

WebKit/chromium/src/WebDeviceOrientationServiceBridgeImpl.cpp:35
 +  #include "WebDeviceOrientationService.h"
alpha order

WebKit/chromium/src/WebDeviceOrientationServiceBridgeImpl.cpp:14
 +   *	   * Neither the name of Google Inc. nor the names of its
2 clause

WebKit/chromium/src/DeviceOrientationClientImpl.h:40
 +  } // namespace WebCore
don't need the //

WebKit/chromium/src/DeviceOrientationClientImpl.cpp:51
 +	  return;
4 spaces