[webkit-reviews] review denied: [Bug 41864] [V8] Navigation policy doesn't play nicely with pepper plugins : [Attachment 60937] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 8 15:19:50 PDT 2010
Adam Barth <abarth at webkit.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 41864: [V8] Navigation policy doesn't play nicely with pepper plugins
https://bugs.webkit.org/show_bug.cgi?id=41864
Attachment 60937: Patch
https://bugs.webkit.org/attachment.cgi?id=60937&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
- if (!callingFrame)
- return;
You removed this null check. Retrieving the frame can fail if the entered
context is associated with an inactive document. In that case, this patch
introduces a crash.
More information about the webkit-reviews
mailing list