[webkit-reviews] review granted: [Bug 41907] Handle whitespace correctly : [Attachment 60963] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41907: Handle whitespace correctly
https://bugs.webkit.org/show_bug.cgi?id=41907

Attachment 60963: Patch
https://bugs.webkit.org/attachment.cgi?id=60963&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTMLTreeBuilder.cpp:104
 +	String takeAll()
Should this be takeRemaining()?

WebCore/html/HTMLTreeBuilder.cpp:112
 +	String takeAllWhitespace()
takeRemainingWhitespace?

WebCore/html/HTMLTreeBuilder.cpp:109
 +	    return String(start, m_current - start);
Could this have an optimized branch which returned the original string if we
never moved m_current?

I like this change.  I think it would be useful to know the performance impact.
 Not that it would actually change us from landing it, but would be useful to
know how much perf we're losing here.