[webkit-reviews] review granted: [Bug 41332] Implement unloadEventEnd, loadEventStart, and loadEventEnd : [Attachment 60813] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 41332: Implement unloadEventEnd, loadEventStart, and loadEventEnd
https://bugs.webkit.org/show_bug.cgi?id=41332

Attachment 60813: Patch
https://bugs.webkit.org/attachment.cgi?id=60813&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
r+ with a nit

> +    if (FrameLoader* frameLoader = frame() ? frame()->loader() : 0)
> +	   frameLoader->frameLoadTimeline()->loadEventStart = currentTime();
>      dispatchEvent(Event::create(eventNames().loadEvent, false, false),
document());
> +    if (FrameLoader* frameLoader = frame() ? frame()->loader() : 0)
> +	   frameLoader->frameLoadTimeline()->loadEventEnd = currentTime();

I find these if statements a bit unclear. You don't need to null check the
FrameLoader, so maybe just set a Frame* in the if() statement.