[webkit-reviews] review granted: [Bug 3652] add support for link prefetching : [Attachment 60883] fat finger begone

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 09:42:32 PDT 2010


Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 3652: add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652

Attachment 60883: fat finger begone
https://bugs.webkit.org/attachment.cgi?id=60883&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/loader/DocLoader.cpp:383
 +	if (res->isPrefetch())
It's slightly better to use something semantic here instead of RTTI.

LayoutTests/fast/dom/HTMLLinkElement/prefetch.html:7
 +	setTimeout("layoutTestController.notifyDone()",50);
Still sad about this line.  This test is going to be flaky, especially on
slower machines and in configurations like valgrind.


More information about the webkit-reviews mailing list