[webkit-reviews] review denied: [Bug 41834] Web Inspector: migrate InspectorDOMAgent to the generated version of InspectorFrontend interface. : [Attachment 60856] [patch] second iteration
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 8 03:17:08 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has denied review:
Bug 41834: Web Inspector: migrate InspectorDOMAgent to the generated version of
InspectorFrontend interface.
https://bugs.webkit.org/show_bug.cgi?id=41834
Attachment 60856: [patch] second iteration
https://bugs.webkit.org/attachment.cgi?id=60856&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/bindings/js/ScriptEventListener.cpp:116
+ return
ustringToString(jsFunction->toString(mainWorldScriptState(document->frame())));
You should use jsListener->isolatedWorld() instead.
WebCore/bindings/v8/ScriptEventListener.cpp:123
+ ScriptState* scriptState = mainWorldScriptState(document->frame());
It should be possible to get it from the listener, something like
static_cast<V8AbstractEventListener*>(listener)->worldContext()
worldContext is protected though.
More information about the webkit-reviews
mailing list