[webkit-reviews] review granted: [Bug 41834] Web Inspector: migrate InspectorDOMAgent to the generated version of InspectorFrontend interface. : [Attachment 60856] [patch] second iteration

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 41834: Web Inspector: migrate InspectorDOMAgent to the generated version of
InspectorFrontend interface.
https://bugs.webkit.org/show_bug.cgi?id=41834

Attachment 60856: [patch] second iteration
https://bugs.webkit.org/attachment.cgi?id=60856&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorDOMAgent.cpp:236
 +	    m_frontend->setDocument(InspectorObject::create());
This should be InspectorValue::null() really. Frontend will support it.


WebCore/inspector/InspectorDOMAgent.cpp:289
 +		m_frontend->childNodeInserted(parentId, prevId,
value.release());
I think this only adds complexity. We should keep ownership and rely upon the
sync nature of the call.

WebCore/inspector/InspectorDOMAgent.cpp:1105
 +	    m_frontend->didGetStyleSheet(callId, InspectorObject::create());
null()