[webkit-reviews] review denied: [Bug 29690] ApplicationCache Events Should Delay Firing Until After Document Load : [Attachment 47566] cleaner patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 29690: ApplicationCache Events Should Delay Firing Until After Document
Load
https://bugs.webkit.org/show_bug.cgi?id=29690

Attachment 47566: cleaner patch
https://bugs.webkit.org/attachment.cgi?id=47566&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This looks very good. Two minor nitpicks Michael agreed to address:

I'd have used a Vector, not a Deque - generally, the former is the best
solution for most data structures, as well as there aren't too many items
expected. It has simpler housekeeping, avoids executable code bloat, and
asymptotic performance characteristics don't matter yet. In WebKit, Deque is
implemented with a Vector anyway.

Also, m_isDeferringEvents should be m_defersEvents for consistency with
m_defersCallbacks elsewhere in the code base.