[webkit-reviews] review granted: [Bug 34003] [GTK] Pass cookies to GStreamer : [Attachment 47624] slomo's patch with my test, as a whole patch

Thu Jan 28 15:08:34 PST 2010

Eric Carlson <eric.carlson at apple.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 34003: [GTK] Pass cookies to GStreamer
https://bugs.webkit.org/show_bug.cgi?id=34003

Attachment 47624: slomo's patch with my test, as a whole patch
https://bugs.webkit.org/attachment.cgi?id=47624&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> diff --git
a/LayoutTests/http/tests/media/resources/video-cookie-check-cookie.html
b/LayoutTests/http/tests/media/resources/video-cookie-check-cookie.html

This file isn't used any more.

> +++ b/LayoutTests/http/tests/media/resources/video-cookie-check-cookie.php
> @@ -0,0 +1,23 @@
> +<?php
> +   if($_COOKIE["TEST"])
> +   {

Three space tabs?

> diff --git a/LayoutTests/http/tests/media/video-cookie.html
b/LayoutTests/http/tests/media/video-cookie.html
> new file mode 100644
> index 0000000..e02b72e
> --- /dev/null
> +++ b/LayoutTests/http/tests/media/video-cookie.html

> +<html>
> +<body onload="loadCookie()">
> +<video id="video"></video>
> +<script src=../../../media/media-file.js></script>

  I would prefer to see the <script> elements in the <head> because they are
triggered by the 'load' event.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 7168d3e..065f7b8 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,18 @@
> +2010-01-25  Sebastian DrÃ¶ge  <sebastian.droege at collabora.co.uk>

  "DrÃ¶ge" - need to save as UTF8?

>  2010-01-22  Sebastian DrÃ¶ge  <sebastian.droege at collabora.co.uk>

  Here too.

  This new test didn't work on the Mac the last time I looked, and I won't be
able to look at it today, so why don't you add it to the skipped list and write
a bug, assigned to me, to figure out why and fix it.

r=me with these changes.