[webkit-reviews] review denied: [Bug 34219] [Gtk] Server message not shown on http authentication : [Attachment 47546] Patch to make server message visible in http authentication dialog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 28 12:32:35 PST 2010
Gustavo Noronha (kov) <gns at gnome.org> has denied José Millán Soto
<jmillan at igalia.com>'s request for review:
Bug 34219: [Gtk] Server message not shown on http authentication
https://bugs.webkit.org/show_bug.cgi?id=34219
Attachment 47546: Patch to make server message visible in http authentication
dialog
https://bugs.webkit.org/attachment.cgi?id=47546&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
196 char *description;
This * is misplaced in comparison to the others.
272 serverMessageLabel =
gtk_label_new(_(soup_auth_get_realm(authData->auth)));
I don't think we want to translate the server's message.
More information about the webkit-reviews
mailing list