[webkit-reviews] review granted: [Bug 33484] [GTK] Add and cleanup return values of signals in view and frame : [Attachment 46297] Add and cleanup return values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 28 12:26:57 PST 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 33484: [GTK] Add and cleanup return values of signals in view and frame
https://bugs.webkit.org/show_bug.cgi?id=33484

Attachment 46297: Add and cleanup return values
https://bugs.webkit.org/attachment.cgi?id=46297&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 1380	   * * Return value: a #WebKitNavigationResponse
 1381	   *

Additional * here.

I would prefer if you leave move-cursor out of this for now, and report a bug
specifically about it. I don't really know whether it should have an
accummulator, or if we should simply make it return void, go ahead with the
rest, though. Thanks!


More information about the webkit-reviews mailing list