[webkit-reviews] review granted: [Bug 34173] style tool: Improve treatment of conditions and rest of the line for if, else, switch and alikes : [Attachment 47544] Next round

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 11:01:08 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 34173: style tool: Improve treatment of conditions and rest of the line for
if, else, switch and alikes
https://bugs.webkit.org/show_bug.cgi?id=34173

Attachment 47544: Next round
https://bugs.webkit.org/attachment.cgi?id=47544&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks again for your fix! Looks good assuming you'll land this after you check
this patch with some code as David suggested (thanks David for your comment, I
somehow missed Anton's question). By the way, I think people rarely ignores
these rules so I guess checking a lot of source code won't be so painful.


More information about the webkit-reviews mailing list