[webkit-reviews] review denied: [Bug 34062] [Qt] Tuning and optimizations to GraphicsLayerQt : [Attachment 47307] First round of performance tunings for QtWebkit accelerated compositing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 27 10:55:12 PST 2010
Ariya Hidayat <ariya.hidayat at gmail.com> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 34062: [Qt] Tuning and optimizations to GraphicsLayerQt
https://bugs.webkit.org/show_bug.cgi?id=34062
Attachment 47307: First round of performance tunings for QtWebkit accelerated
compositing
https://bugs.webkit.org/attachment.cgi?id=47307&action=review
------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
I like the optimization :) Good job, No'am.
My minor concern: can we have a benchmark for this? I mean, there is a few
manual tests out there (I'm sure you use some of them) but I am referring to
QBENCHMARK-type of tests.
A much more quantified speed-up mentioned in the ChangeLog will be very
appreciated, IMO.
r- for this, otherwise looks good!
More information about the webkit-reviews
mailing list