[webkit-reviews] review denied: [Bug 33566] [BREWMP] Port WTF's randomNumber : [Attachment 47252] Port randomNumber and weakRandomNumber

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 14:41:38 PST 2010


Eric Seidel <eric at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 33566: [BREWMP] Port WTF's randomNumber
https://bugs.webkit.org/show_bug.cgi?id=33566

Attachment 47252: Port randomNumber and weakRandomNumber
https://bugs.webkit.org/attachment.cgi?id=47252&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems we should add the #undef to wtf/Assertions.h instead:

Something like what we do for windows:
#if OS(WINDOWS) || OS(SYMBIAN)
/* FIXME: Change to use something other than ASSERT to avoid this conflict with
the underlying platform */
#undef ASSERT
#endif


More information about the webkit-reviews mailing list