[webkit-reviews] review denied: [Bug 30977] [Wx] Don't use global operators new/delete in wx port : [Attachment 42256] Patch disabling global operators new and delete for wx port too

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 14:36:41 PST 2010


Zoltan Horvath <zoltan at webkit.org> has denied Vadim Zeitlin
<vz-webkit at zeitlins.org>'s request for review:
Bug 30977: [Wx] Don't use global operators new/delete in wx port
https://bugs.webkit.org/show_bug.cgi?id=30977

Attachment 42256: Patch disabling global operators new and delete for wx port
too
https://bugs.webkit.org/attachment.cgi?id=42256&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
I mark this patch r- just because we don't need to add these comments into
FastMalloc.h.

Darin summarization about new/delete operators:
https://lists.webkit.org/pipermail/webkit-dev/2010-January/011276.html

As I said, almost all core classes are inherited from FastAllocBase, so
disabling customization of operator new/delete is safe and should not have
performance effect.


More information about the webkit-reviews mailing list